Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run-make: audit raw Command usages #126058

Closed
jieyouxu opened this issue Jun 6, 2024 · 1 comment
Closed

run-make: audit raw Command usages #126058

jieyouxu opened this issue Jun 6, 2024 · 1 comment
Assignees
@jieyouxu
Labels
A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@jieyouxu
Copy link
Member

jieyouxu commented Jun 6, 2024

https://github.com/rust-lang/rust/pull/125752/files would add drop bomps to command wrappers that forces the test writer to check command exit status. However, some rmake.rs tests use raw Command invocations for various reasons, and it's super easy to forget to check for command exit status.

We should probably:

  • Convert Command invocations to command wrappers where reasonable.
  • Introduce something to force a check of the exit status if for some reason a raw Command cannot be converted into a command wrapper.
@jieyouxu jieyouxu added C-cleanup Category: PRs that clean code up or issues documenting cleanup. A-testsuite Area: The testsuite used to check the correctness of rustc labels Jun 6, 2024
@jieyouxu jieyouxu self-assigned this Jun 6, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jun 6, 2024
@jieyouxu jieyouxu added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Jun 6, 2024
@jieyouxu jieyouxu moved this to In progress in Oxidizing run-make tests Jun 6, 2024
@jieyouxu jieyouxu added the A-run-make Area: port run-make Makefiles to rmake.rs label Jun 9, 2024
@jieyouxu
Copy link
Member Author

Addressed with a custom command wrapper in #126121.

@github-project-automation github-project-automation bot moved this from In progress to Done in Oxidizing run-make tests Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jieyouxu jieyouxu

Labels
A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
Oxidizing run-make tests
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jieyouxu @rustbot