Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Japanese translation of Rust by Example is not built #124641

Closed
dalance opened this issue May 3, 2024 · 0 comments · Fixed by #124731
Closed

Japanese translation of Rust by Example is not built #124641

dalance opened this issue May 3, 2024 · 0 comments · Fixed by #124731
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@dalance
Copy link
Contributor

dalance commented May 3, 2024 •
edited
Loading

Location

The language selector of Rust by Example has the link to Japanese translation, but the link target (https://doc.rust-lang.org/rust-by-example/ja/index.html) is not found.

image

Summary

The latest Rust by Example has Japanese translation resource based on mdbook-i18n-helpers.
But the current bootstrap process by ./x doc doesn't build the translation.

If I open a PR to add the translation build process, is it acceptable?
@dalance dalance added the A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools label May 3, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label May 3, 2024
@workingjubilee workingjubilee added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label May 3, 2024
@Noratrieb Noratrieb added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels May 3, 2024
@dalance dalance mentioned this issue May 5, 2024
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jun 5, 2024
@matthiaskrgr
Rollup merge of rust-lang#124731 - dalance:add_translation_support, r…
734fec6 
…=ehuss

Add translation support by mdbook-i18n-helpers to bootstrap

This PR add translation support by [mdbook-i18n-helpers](https://github.com/google/mdbook-i18n-helpers) to bootstrap.
This is draft PR because there is the dependency to my forked mdbook-i18n-helpers.
If this PR is acceptable, I'll send a PR to the original mdbook-i18n-helpers and remove draft after changing the dependency to the original.

Closes rust-lang#124641
@bors bors closed this as completed in 3b6eefe Jun 6, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Jun 6, 2024
@rust-timer
Unrolled build for rust-lang#124731
5782fe3 
Rollup merge of rust-lang#124731 - dalance:add_translation_support, r=ehuss

Add translation support by mdbook-i18n-helpers to bootstrap

This PR add translation support by [mdbook-i18n-helpers](https://github.com/google/mdbook-i18n-helpers) to bootstrap.
This is draft PR because there is the dependency to my forked mdbook-i18n-helpers.
If this PR is acceptable, I'll send a PR to the original mdbook-i18n-helpers and remove draft after changing the dependency to the original.

Closes rust-lang#124641
This was referenced Sep 30, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add translation support by mdbook-i18n-helpers to bootstrap dalance/rust
4 participants
@dalance @workingjubilee @rustbot @Noratrieb