Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiletest: Support aux-bin with cross compilation #124361

Open
Enselic opened this issue Apr 25, 2024 · 0 comments
Open

compiletest: Support aux-bin with cross compilation #124361

Enselic opened this issue Apr 25, 2024 · 0 comments
Labels
A-compiletest Area: The compiletest test runner A-cross Area: Cross compilation A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. E-hard Call for participation: Hard difficulty. Experience needed to fix: A lot. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@Enselic
Copy link
Member

Enselic commented Apr 25, 2024

Step-by-step

  1. src/ci/docker/run.sh --dev armhf-gnu
  2. ../x test --target arm-unknown-linux-gnueabihf tests/ui/compiletest-self-test/test-aux-bin.rs

(Watch out for the problem fixed in #124359.)

Expected

The test is run through the existing remote-test-client / remote-test-server mechanism and passes.

Actual

It is ignored because aux-bin does not work for this case yet:

running 1 tests
test [ui] tests/ui/compiletest-self-test/test-aux-bin.rs ... ignored, ignored when cross-compiling (because aux-bin does not yet support it)

The problem

The problem is simply that the existing remote-test-client / remote-test-server mechanism has not been taught how to deal with aux-bin files.

Compare with

If you run the test without cross compilation it works:

$ ./x test tests/ui/compiletest-self-test/test-aux-bin.rs
running 1 tests
test [ui] tests/ui/compiletest-self-test/test-aux-bin.rs ... ok

Other info

I was asked here to file this issue.

@Enselic Enselic added A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. A-cross Area: Cross compilation T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. labels Apr 25, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Apr 25, 2024
@Enselic Enselic removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Apr 25, 2024
@jieyouxu jieyouxu moved this from Needs Triage / Backlog to Ready in compiletest maintenance and improvements May 29, 2024
@jieyouxu jieyouxu added the A-compiletest Area: The compiletest test runner label May 29, 2024
@jieyouxu jieyouxu added E-hard Call for participation: Hard difficulty. Experience needed to fix: A lot. and removed E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-compiletest Area: The compiletest test runner A-cross Area: Cross compilation A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. E-hard Call for participation: Hard difficulty. Experience needed to fix: A lot. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
Development

No branches or pull requests

3 participants