-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs feature banner will not show on top level docs when using glob export #120487
Comments
Probably #113091, it shouldn't have affected glob re-exports but maybe did (cc @GuillaumeGomez). |
Taking a look. |
Same issue with a simple reexport: mod b {
#[doc(cfg(not(feature = "a")))]
#[cfg(not(feature = "a"))]
pub struct Test2;
}
pub use b::Test2; |
That's what #113091 was meant to do, it wasn't meant to affect globs though. |
Ok so it's the expected output for a non-glob reexport. I wrote the fix for glob reexports, just need to add tests. |
…merge-bugfix, r=notriddle rustdoc: Correctly handle attribute merge if this is a glob reexport Fixes rust-lang#120487. The regression was introduced in rust-lang#113091. Only non-glob reexports should have been impacted. cc `@Nemo157` r? `@notriddle`
…merge-bugfix, r=notriddle rustdoc: Correctly handle attribute merge if this is a glob reexport Fixes rust-lang#120487. The regression was introduced in rust-lang#113091. Only non-glob reexports should have been impacted. cc ``@Nemo157`` r? ``@notriddle``
…merge-bugfix, r=notriddle rustdoc: Correctly handle attribute merge if this is a glob reexport Fixes rust-lang#120487. The regression was introduced in rust-lang#113091. Only non-glob reexports should have been impacted. cc ```@Nemo157``` r? ```@notriddle```
…merge-bugfix, r=notriddle rustdoc: Correctly handle attribute merge if this is a glob reexport Fixes rust-lang#120487. The regression was introduced in rust-lang#113091. Only non-glob reexports should have been impacted. cc ````@Nemo157```` r? ````@notriddle````
Rollup merge of rust-lang#120501 - GuillaumeGomez:glob-reexport-attr-merge-bugfix, r=notriddle rustdoc: Correctly handle attribute merge if this is a glob reexport Fixes rust-lang#120487. The regression was introduced in rust-lang#113091. Only non-glob reexports should have been impacted. cc `````@Nemo157````` r? `````@notriddle`````
@GuillaumeGomez Latest nightly fixed the issue for #![feature(doc_auto_cfg)]
mod a {
#[cfg(feature = "a")]
pub struct Test1;
}
pub use a::*; its last working version was also |
Noted. Sending a fix for it as well. :) |
Fixed in #120548. |
…erge, r=GuillaumeGomez rustdoc: Fix handling of doc_auto_cfg feature for cfg attributes on glob reexport This is a follow-up of rust-lang#120501 and a part of rust-lang#120487. r? `@notriddle`
Rollup merge of rust-lang#120548 - GuillaumeGomez:glob-reexport-cfg-merge, r=GuillaumeGomez rustdoc: Fix handling of doc_auto_cfg feature for cfg attributes on glob reexport This is a follow-up of rust-lang#120501 and a part of rust-lang#120487. r? `@notriddle`
I tried this code:
I expected to see this happen:
Instead, this happened:
This is issue from
nightly-2023-12-16.
First screenshot is ofnightly-2023-12-15
and second is ofnightly-2023-12-16
The text was updated successfully, but these errors were encountered: