-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crate_type = "lib" means a dynamic lib #11253
Comments
Should lib mean build both since it's unspecific? |
I have defined this in the manual as the "compiler recommended" format of library. When I initially added rlibs, they weren't good enough to make the default. I believe that may have changed now, so perhaps it could become the default. I'm a little wary of generating both formats, but it's an interesting idea and may actually be the best thing to do. Regardless, this warrants discussion. |
+1 for creating a static lib (this means What would the use case be for creating both? |
What should happen if crate_type isn't set? I've implemented static lib as a default and it breaks a lot of tests ... :/ |
staticlib and rlib are two different outputs. The compiler will attempt to link rlibs together, and the compiler will never look at staticlibs (staticlibs are meant for integration with existing projects). I do not believe the default should change until we have discussed this further. |
Assigning to P-high. (I'm not 100% convinced that there isn't a backcompat risk; but that depends on how one defines the relationship between docs, users, and backcompat.) |
We decided in today's meeting to continue making |
It should mean a static lib.
The text was updated successfully, but these errors were encountered: