Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implied_by not working with const-stability? #107605

Closed
steffahn opened this issue Feb 2, 2023 · 0 comments · Fixed by #107801
Closed

implied_by not working with const-stability? #107605

steffahn opened this issue Feb 2, 2023 · 0 comments · Fixed by #107801
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@steffahn
Copy link
Member

steffahn commented Feb 2, 2023

@rustbot label T-compiler, C-enhancement

Opening an issue for the problem described in #99212 (comment)

Context: The only use-case of implied_by that’s currently on nightly was introduced in #102556, but as far as I can tell, that doesn’t actually do anything. Given that the general implied_by feature has a behavior test, I would assume that the problem is that it isn’t working with (and isn’t tested with) rustc_const_unstable/rustc_const_stable instead of unstable/stable.

cc @davidtwco
@rustbot rustbot added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 2, 2023
@davidtwco davidtwco mentioned this issue Feb 8, 2023
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 6, 2023
@matthiaskrgr
Rollup merge of rust-lang#107801 - davidtwco:stability-implies-const,…
99df510 
… r=Nilstrieb

const_eval: `implies_by` in `rustc_const_unstable`

Fixes rust-lang#107605.

Extend support for `implies_by` (from `#[stable]` and `#[unstable]`) to `#[rustc_const_stable]` and `#[rustc_const_unstable]`.

cc `@steffahn`
@bors bors closed this as completed in 9c99a4c Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

const_eval: implies_by in rustc_const_unstable davidtwco/rust
2 participants
@steffahn @rustbot