Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc removes feature flag labels for re-exports #102250

Closed
andrewbanchich opened this issue Sep 25, 2022 · 3 comments
Closed

rustdoc removes feature flag labels for re-exports #102250

andrewbanchich opened this issue Sep 25, 2022 · 3 comments
Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@andrewbanchich
Copy link
Contributor

tower::service_fn, for example, says nothing about feature flags you need to enable, even though it is behind the utils flag. This makes it fairly confusing.

The service_fn in the crate root is just a reexport of tower::utils::service_fn, which is correctly marked as behind a feature flag.
@andrewbanchich andrewbanchich added the C-bug Category: This is a bug. label Sep 25, 2022
@crlf0710 crlf0710 added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Sep 25, 2022
@GuillaumeGomez
Copy link
Member

Another re-export issue. I'll take a look at it.

@GuillaumeGomez
Copy link
Member

Just to be sure: did you try with a more recent nightly? I fixed a similar issue in #101006.

@andrewbanchich
Copy link
Contributor Author

It does seem to be fixed on nightly. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@crlf0710 @GuillaumeGomez @andrewbanchich