Resolve the biggest blockers to Linux building on stable Rust

[nikomatsakis]

Metadata
Owner(s)	@nikomatsakis, @joshtriplett
Team(s)	compiler, lang, libs-api
Goal document	2024h2/rfl_stable
See also	rust-lang/rust#44874

Summary

Stabilize unstable features required by Rust for Linux project including

• Stable support for RFL's customized ARC type
• Labeled goto in inline assembler and extended offset_of! support
• RFL on Rust CI
• Pointers to statics in constants

Tasks and status

• Overall program management (@nikomatsakis, @joshtriplett)

• Arbitrary self types v2 (@adetaylor) -- tracked in Tracking issue for RFC 3519: arbitrary_self_types rust#44874

• Derive smart pointer (@Darksonn)

  • author RFC
  • RFC decision (lang )
  • Settle naming question Decide on name for derive(SmartPtr) rust#129104
  • Implementation (@dingxiangfei2009) -- Rename macro SmartPointer to CoercePointee rust#131284
  • Review and merge Rename macro SmartPointer to CoercePointee rust#131284 (compiler )
  • Patch kernel to use new functionality -- authorship has begun but not yet submitted to the kernel
  • Author stabilization report (@dingxiangfei2009)
  • Stabilization decision (lang )

• asm_goto (@Darksonn)

  • implementation
  • Real-world usage in Linux kernel
  • Decide on asm-goto blocks being safe-by-default (Decide whether blocks inside asm goto should default to safe rust#132078) (lang ) -- currently in FCP
  • Implement safe-by-default Make asm label blocks safe context rust#131544
  • Review and merge safe-by-default Make asm label blocks safe context rust#131544 (compiler )
  • Split asm goto with outputs to separate feature gate Fix asm goto with outputs and move it to a separate feature gate rust#131523
  • Decide on const-embedded pointers Support for pointers with asm_const rust#128464
    • current status: nominated
  • Implement const-embedded pointers (in progress)
    • WIP https://github.com/nbdd0121/rust/tree/asm_const_ptr
  • Author stabilization report
  • Stabilization decision (lang )

• Extended offset_of syntax (@dingxiangfei2009)

  • Stabilization report
  • Stabilization decision (libs-api )
  • Stabilization PR Stabilize offset_of_nested rust#128284

• RFL on Rust CI (@Kobzol)

  • implementation
  • Policy draft
  • Policy decision (compiler )
    • davidtwco took a look, updated dev-guide, this is all good now

• Pointers to static in constants (@nikomatsakis) -- Tracking Issue for const_refs_to_static rust#119618

  • Stabilization report (Proposal: stabilize const_refs_to_static rust#128183)
  • Stabilization decision (lang )
  • Stabilization PR Stabilize const_refs_to_static rust#129759
  • Reference updates const expression can borrow static items reference#1610

• Compiler flags like fixed-x18

  • RFC opened [RFC] Target Modifiers rfcs#3716
  • RFC reviewed by compiler team: davidtwco to read through thread, wesleywiser to give a callout
  • Implementation
  • Stabilization

[nikomatsakis]

This issue is intended for status updates only.

For general questions or comments, please contact the owner(s) directly.

[nikomatsakis]

Key developments:

• Implementation work is proceeding in many areas (arbitrary self types v2, derive smart pointer, and sanitizer support.
• Extended offset_of syntax is stable on nightly! 🎉 Credit to @dingxiangfei2009 for driving this.
• RFL on Rust CI is implemented but still waiting on documented policy. The first breakage was detected (and fixed) in #129416. Reading over the PR comments suggests that the policy has not been well communicated to the Rust devs, who weren't clear on who was responsible to fix the breakage etc. Suggested follow-up is to improve the bot message to link to the policy and (as an interim measure) send an email to all@ and post an Inside Rust blog post.
• Stabilization report for Pointers to Statics in Constants is now in FCP. @dingxiangfei2009 to prepare stabilization PR. 💜

Next steps

• Need to decide on a name for derive-smart pointer. @nikomatsakis to follow-up.
• Experimentation with asm-goto has revealed that a weak point in the design. A typical use case for this feature is to design control-flow, where you have some assembly code that decides which block to branch to. The current design looks like inline_asm!(..., exit1 = { ... }, exit2 = { ... }), in which the assembly code can jump to exit1 or exit2. The problem is that, since inline_asm! must be in an unsafe block, this implies the blocks associated with those labels will be allowed to use unsafe code. To circumvent this, the RFL team is having those blocks simply break from an outer block with a false return value, and then branching on that if value outside. That's the same as the C code does, as it happens, but. it's not as nice nor efficient as it could be. Discussion in the meeting suggested that the block bodies should be limited to safe code unless marked as unsafe. @joshtriplett to follow-up.
• For Sanitizer support, we will need to stabilize the -Zfixed-x18 flag as a first step. @Darksonn to start drafting a stabilization report, possibly delegating some questions to @nikomatsakis.

[nikomatsakis]

Key developments:

• Kangrejos, the Rust for Linux Workshop, took place Sep 7-8 in Copenhagen. Session listing and slides are available on https://kangrejos.com.
• @Darksonn has opened RFC #3716 proposing an approach to manage compiler flags that modify the target ABI and which therefore are only sound if used by all crates. The kernel makes use of a wide number of such flags and it is not practical to have a distinct target for all of the possible combinations. In authoring the RFC it was discovered that there are more such flags than were previously recognized, such as flags that modify LLVM behavior.
• Due to the fact that an increasing number of discussion topics had to do with the compiler, @wesleywiser and @davidtwco from the compiler team have started to join our meetings, which has been helpful in getting faster input from the compiler team.
• The final naming for the "derive-smart-pointer" feature has been settled; it will henceforth be called #[derive(CoercePointee)]. @dingxiangfei2009 prepared PR #131284 to do the rename and is preparing a patch and PR to the rust-for-linux repository.
• @nbdd0121 authored a hackmd outlining RFL's experiences with the asm-goto feature and in particular areas for improvement. From this we derived two immediate action items, making the target blocks safe-by-default (Tracking Issue for asm_goto rust#119364) and extending const to support embedded pointers (Support for pointers with asm_const rust#128464).

Next steps:

• RFC #3716 to be considered by the compiler team.
• Land PR Rename macro SmartPointer to CoercePointee rust#131284 and port code in the Rust-for-Linux repo to use it. Author stabilization report.
• Once FCP completes on Decide whether blocks inside asm goto should default to safe rust#132078, review and merge Make asm label blocks safe context rust#131544 making asm-goto target blocks safe-by-default.
• Decide on extending const to support embedded pointers (Support for pointers with asm_const rust#128464).
• Stabilization PR for embedding pointers to statics in constants (to be done by @dingxiangfei2009)

[nikomatsakis]

Brief updates from today's meeting (minutes):

• Discussed what goal to set for the next round of project goals. Miguel to prepare a candidate list of stabilization targets, prioritizing language changes (which require widespread edits to the codebase to rebase over) and outright hacks (as is used with rustdoc) and otherwise focusing on "what is needed to get some concrete production use case working". Candidate production use cases we discussed are the android linux kernel configuration or the configuration used by a popular linux distro.
• Discussed synchronization with Debian to see if we can ensure that the version of Rust in their next LTS includes support for Rust 2024, which would make it much easier for the RfL work (along with other crates in the ecosystem) to migrate.
• Compiler team documented policy with respect to RfL on their CI, so that item is done.
• Stabilizationj PR for pointers-to-statics-in-constants (Tracking Issue for const_refs_to_static rust#119618) has landed and is stable on nightly, work is needed to update the reference.
• RFC for ABI-relevant compiler flags ([RFC] Target Modifiers rfcs#3716) to be reviewed by compiler team and moved to FCP if appropriate. @wesleywiser to call attention to it in the next compiler team meeting.