Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit assembly comments in the disassembly #397

Closed
GabrielMajeri opened this issue Sep 2, 2018 · 1 comment
Closed

Emit assembly comments in the disassembly #397

GabrielMajeri opened this issue Sep 2, 2018 · 1 comment
Labels
enhancement Something new the playground could do

Comments

@GabrielMajeri
Copy link
Contributor

GabrielMajeri commented Sep 2, 2018

Pull request rust-lang/rust#53290 added the (nightly only) option -Z asm-comments, which makes LLVM emit comments in the disassembly, making it much more readable.

It would be awesome if the Rust playground could enable this flag in the disassembly view (for nightly builds, at least until it stabilises), possibly unconditionally (I don't think it has any downsides).

For implementation, I think it might be enough to add the flag here? Only issue I found is that that function doesn't have a parameter which would allow it to determine if it runs on nightly or not.

@shepmaster shepmaster added enhancement Something new the playground could do help wanted Not immediately going to be prioritized — ask for mentoring instructions! labels Sep 14, 2018
@shepmaster
Copy link
Member

shepmaster commented Sep 14, 2018

For implementation, I think it might be enough to add the flag here? Only issue I found is that that function doesn't have a parameter which would allow it to determine if it runs on nightly or not.

I think you are right. Would you care to take this enhancement on?

I think just adding the channel as an argument to that function is fine. At some point we will need to step back and re-evaluate how all that stuff interacts, but not right now... 😉

@shepmaster shepmaster removed the help wanted Not immediately going to be prioritized — ask for mentoring instructions! label Sep 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something new the playground could do
Projects
None yet
Development

No branches or pull requests

2 participants