Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better detect when a field can be moved from in while_let_on_iterator #8221

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Jan 4, 2022

fixes #8113

changelog: Better detect when a field can be moved from in while_let_on_iterator

@rust-highfive
Copy link

r? @llogiq

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 4, 2022
@llogiq
Copy link
Contributor

llogiq commented Jan 4, 2022

Nice improvement! Thank you! @bors r+

@bors
Copy link
Contributor

bors commented Jan 4, 2022

📌 Commit ff58efb has been approved by llogiq

@bors
Copy link
Contributor

bors commented Jan 4, 2022

⌛ Testing commit ff58efb with merge f2ea5fb...

bors added a commit that referenced this pull request Jan 4, 2022
Better detect when a field can be moved from in `while_let_on_iterator`

fixes #8113

changelog: Better detect when a field can be moved from in `while_let_on_iterator`
@bors
Copy link
Contributor

bors commented Jan 5, 2022

💥 Test timed out

@llogiq
Copy link
Contributor

llogiq commented Jan 5, 2022

@bors retry

@bors
Copy link
Contributor

bors commented Jan 5, 2022

⌛ Testing commit ff58efb with merge 92048f4...

@bors
Copy link
Contributor

bors commented Jan 5, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 92048f4 to master...

@bors bors merged commit 92048f4 into rust-lang:master Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect suggestion in while_let_on_iterator if iterator cannot be moved
4 participants