-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated changelog for 1.55 #7498
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just 2 things everything else LGTM. Thanks for doing this!
- No need to mention this
- We could introduce a new section on top of the list for important changes. Not sure how to name this though.
- I had done the same thing
- I don't mind
Thank you for the feedback! I'll fix the NITs later today, that should definitely be in time for the sync tomorrow 🙃
How about something like Highlight or Major changes ? |
How about "Important Changes"? Stabilizing something is not necessarily a "Major" change. |
Just put it at the top without a header? |
Absolutely not. This is a professional work environment. |
Also a good idea. +1 for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will merge once release is done.
Rename two lints to comply with our lint naming convention self_named_constructor -> self_named_constructors append_instead_of_extend -> extend_with_drain We don't need to `register_renamed` those lints, since I'll backport them to beta, so the old names won't hit stable. changelog: none (I'll adapt the changelog before merging #7498)
Co-authored-by: Philipp Krones <[email protected]> Co-authored-by: Takayuki Nakata <[email protected]>
@bors r+ |
📌 Commit fdf29c0 has been approved by |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This has again been a bit of work, but I'm happy to notice that my English is still improving, and I'm getting faster at these things. That's a very nice side effect of contributing and getting feedback on reviews 😊
Moving on, there were a few things that I was unsure about:
cargo clippy --fix
is quite awesome and important IMO. It sadly gets a bit lost in the Other entry, as it's the last one. Do we maybe want to move it somewhere else or change the headline order for this release?suspicious
group under the Moves and Deprecations section. Is this alright, or should it be moved to the Other section as well?cargo clippy --fix
entry, is this okay?Sorry for the bombardment of questions xD
The PR already includes the entries for the new metadata collection and website updates. These are not merged yet, but should probably be to make this correct. This might also require the commit hashes to be updated (Not sure on this, though). It would actually be super fitting to get this into this release as we also stabilize
--fix
. TODOs:Rendered 📰
r? @flip1995
changelog: none