Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated changelog for 1.55 #7498

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Updated changelog for 1.55 #7498

merged 1 commit into from
Jul 29, 2021

Conversation

xFrednet
Copy link
Member

@xFrednet xFrednet commented Jul 28, 2021

This has again been a bit of work, but I'm happy to notice that my English is still improving, and I'm getting faster at these things. That's a very nice side effect of contributing and getting feedback on reviews 😊

Moving on, there were a few things that I was unsure about:

  • The PR Rename some Rust 2021 lints to better names  rust#86717 changes an old entry in the change log, is this worth mentioning? I've left it out for now.
  • The stabilization of cargo clippy --fix is quite awesome and important IMO. It sadly gets a bit lost in the Other entry, as it's the last one. Do we maybe want to move it somewhere else or change the headline order for this release?
  • I've listed the introduction of the new suspicious group under the Moves and Deprecations section. Is this alright, or should it be moved to the Other section as well?
  • Last but definitely not least, some fun! I've used the 🎉 emoji in the cargo clippy --fix entry, is this okay?

Sorry for the bombardment of questions xD


The PR already includes the entries for the new metadata collection and website updates. These are not merged yet, but should probably be to make this correct. This might also require the commit hashes to be updated (Not sure on this, though). It would actually be super fitting to get this into this release as we also stabilize --fix. TODOs:


Rendered 📰

r? @flip1995

changelog: none

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 28, 2021
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 things everything else LGTM. Thanks for doing this!

  • No need to mention this
  • We could introduce a new section on top of the list for important changes. Not sure how to name this though.
  • I had done the same thing
  • I don't mind

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@flip1995 flip1995 added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Jul 28, 2021
@xFrednet
Copy link
Member Author

Thank you for the feedback! I'll fix the NITs later today, that should definitely be in time for the sync tomorrow 🙃

We could introduce a new section on top of the list for important changes. Not sure how to name this though.

How about something like Highlight or Major changes ?

@flip1995
Copy link
Member

How about "Important Changes"? Stabilizing something is not necessarily a "Major" change.

@camsteffen
Copy link
Contributor

camsteffen commented Jul 28, 2021

  • The stabilization of cargo clippy --fix is quite awesome and important IMO. It sadly gets a bit lost in the Other entry, as it's the last one. Do we maybe want to move it somewhere else or change the headline order for this release?

Just put it at the top without a header?

@camsteffen
Copy link
Contributor

I've used the 🎉 emoji in the cargo clippy --fix entry, is this okay?

Absolutely not. This is a professional work environment.

@flip1995
Copy link
Member

Just put it at the top without a header?

Also a good idea. +1 for that.

@xFrednet
Copy link
Member Author

Having it without a headline is a possibility but than it seems to be a bit like an outsider IMO

image

vs:

image

So I would add the Important Changes if that works for everyone 🙃

Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge once release is done.

bors added a commit that referenced this pull request Jul 29, 2021
Rename two lints to comply with our lint naming convention

self_named_constructor -> self_named_constructors
append_instead_of_extend -> extend_with_drain

We don't need to `register_renamed` those lints, since I'll backport them to beta, so the old names won't hit stable.

changelog: none
(I'll adapt the changelog before merging #7498)
Co-authored-by: Philipp Krones <[email protected]>
Co-authored-by: Takayuki Nakata <[email protected]>
@flip1995
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jul 29, 2021

📌 Commit fdf29c0 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Jul 29, 2021

⌛ Testing commit fdf29c0 with merge b3b2024...

@bors
Copy link
Contributor

bors commented Jul 29, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing b3b2024 to master...

@bors bors merged commit b3b2024 into rust-lang:master Jul 29, 2021
@xFrednet xFrednet deleted the changelog-1-55 branch August 18, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants