-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changelog for 1.48 beta #6115
Conversation
I'm against that. I really do appreciate the work all of the volunteers are doing, don't get me wrong. But I don't think this benefits anyone. Users of Clippy don't want/need to know who did the work, just that it works. Also Clippy contributions are already tracked at https://thanks.rust-lang.org. You can even change your GitHub tag there with your real name, which might be useful for your CV, if companies look at something like open source contributions. (I have it in my CV lol 😄). |
Alright, those seem fair points. At that moment it seemed like a good way to give something back for all the work (some recognition), but I think you're right and the changelog is not the place to do that. |
@bors r+ Thanks! And this concludes the release process 🎉 |
📌 Commit 13781ae has been approved by |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Rendered
I've not added the PRs fixing
same_item_push
because those were backported, namely:The following PR was reverted, so I've ignored it too:
Also, I took the liberty of adding a "Thanks" section, naming all the contributors to this release. I think they deserve visibility in the changelog. Please tell me if we want to add this or maybe it's redundant given we link to the PRs?changelog: none
r? @flip1995