Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail bors on missing changelog #5652

Merged
merged 1 commit into from
May 27, 2020
Merged

Fail bors on missing changelog #5652

merged 1 commit into from
May 27, 2020

Conversation

flip1995
Copy link
Member

@flip1995 flip1995 commented May 26, 2020

Bors stopped failed if the changelog was missing. Instead it waited 2h (?) and then timed out.

changelog: none

@rust-highfive
Copy link

r? @yaahc

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 26, 2020
@flip1995
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented May 26, 2020

⌛ Trying commit 58429c7 with merge 56fef0a...

bors added a commit that referenced this pull request May 26, 2020
Fail bors on missing changelog

Bors stopped failed if the changelog was missing. Instead it waited 2h (?) and then timed out.
@bors
Copy link
Contributor

bors commented May 26, 2020

💔 Test failed - checks-action_test

@flip1995
Copy link
Member Author

@bors try (now it should succeed)

@bors
Copy link
Contributor

bors commented May 26, 2020

⌛ Trying commit 58429c7 with merge e2eeff9...

bors added a commit that referenced this pull request May 26, 2020
Fail bors on missing changelog

Bors stopped failed if the changelog was missing. Instead it waited 2h (?) and then timed out.

changelog: none
@bors
Copy link
Contributor

bors commented May 26, 2020

☀️ Try build successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Build commit: e2eeff9 (e2eeff9723bf4b2f94bfabf274085ada3057b228)

@flip1995
Copy link
Member Author

@bors r=yaahc

Feel free to r+ by yourself, if you feel comfortable 👍

@bors
Copy link
Contributor

bors commented May 27, 2020

📌 Commit 58429c7 has been approved by yaahc

@bors
Copy link
Contributor

bors commented May 27, 2020

⌛ Testing commit 58429c7 with merge f55c3a9...

bors added a commit that referenced this pull request May 27, 2020
Fail bors on missing changelog

Bors stopped failed if the changelog was missing. Instead it waited 2h (?) and then timed out.

changelog: none
@bors
Copy link
Contributor

bors commented May 27, 2020

💔 Test failed - checks-action_test

@flip1995
Copy link
Member Author

@bors retry

@bors
Copy link
Contributor

bors commented May 27, 2020

⌛ Testing commit 58429c7 with merge 7ea7cd1...

@bors
Copy link
Contributor

bors commented May 27, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: yaahc
Pushing 7ea7cd1 to master...

@bors bors merged commit 7ea7cd1 into master May 27, 2020
@flip1995 flip1995 deleted the flip1995-patch-1 branch May 27, 2020 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants