Rustup to rustc 1.36.0-nightly (13fde05b1 2019-05-03) #4061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oops, forgot to make it a draft. oh well. |
Manishearth
force-pushed
the
rustup
branch
3 times, most recently
from
e43eddc to
075f302
Compare
|
It builds now |
Manishearth
changed the title
|
@bors r+ |
|
📌 Commit d618637 has been approved by |
bors
added a commit
that referenced
this pull request
May 4, 2019
Rustup to rustc 1.36.0-nightly (13fde05 2019-05-03) Trying to deal with changes from rust-lang/rust#60462 Moved from #4060 so everyone can collab on the rustup branch.
|
☀️ Test successful - checks-travis, status-appveyor |
eddyb
reviewed
May 4, 2019
| @@ -213,7 +213,7 @@ pub fn match_path_ast(path: &ast::Path, segments: &[&str]) -> bool { | |||
| } | |||
|
|
|||
| /// Gets the definition associated to a path. | |||
| pub fn path_to_def(cx: &LateContext<'_, '_>, path: &[&str]) -> Option<def::Def> { | |||
| pub fn path_to_res(cx: &LateContext<'_, '_>, path: &[&str]) -> Option<(def::Res)> { | |||
There was a problem hiding this comment.
Oops I had forgotten to comment about the strange parens in the return type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to deal with changes from rust-lang/rust#60462
Moved from #4060 so everyone can collab on the rustup branch.