Make dogfood test output to seperate directory #2605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 1, 2018 09:44
This commit makes `cargo clippy` output the build artifacts to a separate directory if the `CLIPPY_DOGFOOD` env var is set. This should prevent dogfood builds from interfering with regular builds. This should help with issue #2595.
|
The build is failing because |
|
Oh that's why this didn't work! Would you be so kind and fix clippy? |
added 7 commits
April 2, 2018 07:04
Allow `many_single_char_names` on `SpanlessHash::hash_expr`. Each variable has a small scope and the method is readable.
Fix `option_option` warning on `to_const_range` by taking the entire range as an parameter instead of the start and end.
Fix cyclomatic_complexity warning on `check_expr` by allowing it. This is preferable to increasing the threshold every time the method changes.
Fix too_many_arguments on `check_general_case` by allowing it. I can't see a sensible way of grouping the parameters.
|
Thanks! |
ghost
deleted the
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes
cargo clippyoutput the build artifacts to aseparate directory if the
CLIPPY_DOGFOODenv var is set. This shouldprevent dogfood builds from interfering with regular builds.
This should help with issue #2595.