Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not suggest to use the closed interval syntax #2217

Closed
leonardo-m opened this issue Nov 8, 2017 · 3 comments · Fixed by #5057
Closed

Do not suggest to use the closed interval syntax #2217

leonardo-m opened this issue Nov 8, 2017 · 3 comments · Fixed by #5057
Labels
S-needs-discussion Status: Needs further discussion before merging or work can be started

Comments

@leonardo-m
Copy link

I suggest to remove or disable this:
https://rust-lang-nursery.github.io/rust-clippy/master/index.html#range_plus_one

Because in some cases the ..= closed intervals are slower (less efficient) than regular intervals.
@oli-obk oli-obk added the S-needs-discussion Status: Needs further discussion before merging or work can be started label Nov 8, 2017
@oli-obk
Copy link
Contributor

oli-obk commented Nov 8, 2017

Do you have any sources about the slowdown?

@leonardo-m
Copy link
Author

An example here:
rust-lang/rust#45222

@sinkuu sinkuu mentioned this issue Jan 3, 2020
Closed
@flip1995 flip1995 mentioned this issue Jan 15, 2020
Closed
@dalcde
Copy link

dalcde commented Jan 17, 2020

This issue still persists. It would be helpful to at least note this in the "Known problems" section.

@llogiq llogiq mentioned this issue Jan 17, 2020
Merged
@bors bors closed this as completed in 7ae2442 Jan 18, 2020
@saethlin saethlin mentioned this issue Oct 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S-needs-discussion Status: Needs further discussion before merging or work can be started
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Downgrade range_plus_one to pedantic rust-lang/rust-clippy
3 participants
@oli-obk @dalcde @leonardo-m