Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint direct calls to deref or deref_mut #1566

Closed
clarfonthey opened this issue Feb 21, 2017 · 5 comments · Fixed by #5226
Closed

Lint direct calls to deref or deref_mut #1566

clarfonthey opened this issue Feb 21, 2017 · 5 comments · Fixed by #5226
Labels
A-lint Area: New lints good-first-issue These issues are a good way to get started with Clippy L-style Lint: Belongs in the style lint group T-middle Type: Probably requires verifiying types

Comments

@clarfonthey
Copy link
Contributor

Instead of calling x.deref() or x.deref_mut(), &*x and &mut *x should be recommended instead.
@ishitatsuyuki
Copy link
Contributor

+1. This should tagged as easy (and attract some bored people from TWiR).

@oli-obk oli-obk added L-style Lint: Belongs in the style lint group good-first-issue These issues are a good way to get started with Clippy A-lint Area: New lints T-middle Type: Probably requires verifiying types labels Mar 11, 2017
@oli-obk
Copy link
Contributor

oli-obk commented Mar 11, 2017

Probably should not lint if it's part of a method chain

@tommilligan
Copy link
Contributor

I'd like to take this if still valid

@tommilligan tommilligan mentioned this issue Oct 4, 2018
Closed
@ThibsG
Copy link
Contributor

ThibsG commented Jan 12, 2020

Can we consider this one done?
Seems that trigger failed on 'Closes' in the PR

@oli-obk
Copy link
Contributor

oli-obk commented Jan 13, 2020

The PR was closed due to inactivity, so this hasn't been merged yet.

@bonzini bonzini mentioned this issue Feb 19, 2020
Merged
@ThibsG ThibsG mentioned this issue Feb 25, 2020
Merged
@bors bors closed this as completed in 3481bf4 Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-lint Area: New lints good-first-issue These issues are a good way to get started with Clippy L-style Lint: Belongs in the style lint group T-middle Type: Probably requires verifiying types
Projects
None yet
Milestone
No milestone
6 participants
@oli-obk @Manishearth @tommilligan @ishitatsuyuki @ThibsG @clarfonthey