False positive unfulfilled_lint_expectations for enum_glob_use with --all-targets or --tests

[lnicola]

Summary

unfulfilled_lint_expectations seems to trigger for enum_glob_use when either --all-targets or --tests is used. Yet other lints, like unreadable_literal don't behave that way.

rust-lang/rust#130021
rust-lang/rust-analyzer#17685

Lint Name

enum_glob_use

Reproducer

I tried this code:

#![warn(clippy::pedantic)]

#[expect(clippy::enum_glob_use)]
use std::cmp::Ordering::*;

fn main() {
    #[expect(clippy::unreadable_literal)]
    let _ = 1000000000;
    print!("{Equal:?}");
}

I saw this happen:

$ cargo clippy --all-targets
warning: this lint expectation is unfulfilled
 --> src/main.rs:3:10
  |
3 | #[expect(clippy::enum_glob_use)]
  |          ^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unfulfilled_lint_expectations)]` on by default

warning: `hello` (bin "hello" test) generated 1 warning
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.00s

I expected to see this happen:

$ cargo clippy
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.00s

Version

rustc 1.81.0-beta.6 (b5fd9f6f1 2024-08-21)
binary: rustc
commit-hash: b5fd9f6f1061b79c045cc08fe03e00caad536800
commit-date: 2024-08-21
host: x86_64-unknown-linux-gnu
release: 1.81.0-beta.6
LLVM version: 18.1.7

Additional Labels

No response

[Urgau]

The lint emission is gated behind the compilation unit NOT behind a test harness generation, it shouldn't be.

rust-clippy/clippy_lints/src/wildcard_imports.rs

Lines 119 to 121 in fb9913e

	if cx.sess().is_test_crate() {
	return;
	}

[junbl]

Same issue with both missing_docs and clippy::missing_docs_in_private_items, unfulfilled lint on all_targets and tests and nothing otherwise:

> cargo clippy 
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.03s
> cargo clippy --all-targets
warning: this lint expectation is unfulfilled
 --> src/main.rs:5:10
  |
5 | #[expect(clippy::missing_docs_in_private_items)]
  |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unfulfilled_lint_expectations)]` on by default

warning: `playground` (bin "playground" test) generated 1 warning
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.00s

with this code:

#![deny(clippy::missing_docs_in_private_items)]

#[expect(clippy::missing_docs_in_private_items)]
const WHO_AM_I: () = ();

[dragonrider7225]

Same issue with both missing_docs and clippy::missing_docs_in_private_items, unfulfilled lint on all_targets and tests and nothing otherwise:

It's worth noting that in the case of missing_docs, this issue has been resolved as of rustc 1.83.0: [https://github.com/rust-lang/rust/pull/130025].