Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking Issue for tuple_array_conversions #11151

Open
3 of 5 tasks
dswij opened this issue Jul 13, 2023 · 2 comments
Open
3 of 5 tasks

Tracking Issue for tuple_array_conversions #11151

dswij opened this issue Jul 13, 2023 · 2 comments
Labels
E-help-wanted Call for participation: Help is requested to fix this issue. S-needs-discussion Status: Needs further discussion before merging or work can be started

Comments

@dswij
Copy link
Member

dswij commented Jul 13, 2023 •
edited
Loading

Description

tuple_array_conversions was moved to nursery because of false positives. This issue tracks the FPs that need to be fixed before it can be moved back to complexity.

Tasks
Beta Give feedback
  1. tuple_array_conversions lint makes code less readable when slice is involved #11082
    C-bug I-false-positive
  2. tuple_array_conversions suggested code erases binding names and hides asymmetry #11085
    C-bug I-false-positive
  3. tuple_array_conversions misses implicit &mut -> & conversion subtelty #11100
    C-bug I-false-positive I-suggestion-causes-error L-complexity
  4. tuple_array_conversions triggers even when binding is used for more than tuple-array conversion #11124
    C-bug I-false-positive
  5. tuple_array_conversion false positive on destructured tuple values #11144
    C-bug I-false-positive
@dswij dswij added the E-help-wanted Call for participation: Help is requested to fix this issue. label Jul 13, 2023
@Alexendoo
Copy link
Member

I think a discussion is warranted before increasing the lint level, personally I find the suggested replacement substantially less readable

@dswij dswij added the S-needs-discussion Status: Needs further discussion before merging or work can be started label Jul 13, 2023
@dswij
Copy link
Member Author

dswij commented Jul 13, 2023

I think a discussion is warranted before increasing the lint level, personally I find the suggested replacement substantially less readable

Fair enough, I'll bring this up in Zulip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-help-wanted Call for participation: Help is requested to fix this issue. S-needs-discussion Status: Needs further discussion before merging or work can be started
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Alexendoo @dswij