-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support markdown in C++ doc comments. #800
Comments
I just don't think we should default to doc comments. For me, the only reason to use doc comments would be if rustdoc could do something sane with them. More often than not, that's not going to be the case with comments imported from C. From your comment in the other thread:
Instead, sending the comments through rustdoc will either error or provide terrible-looking output. Why not just use regular comments? In the future we can have code that detects doxygen or other common documentation styles and convert them to rust-compatible markdown. Maybe there's a way to tell rustdoc "don't format this entire comment, escape it and include it as HTML text verbatim". That would also be ok I think. |
I agree that the most practical thing to do is generate regular, non-doc comments. |
This just broke for me.
|
now that #2347 landed. This can be solved by implementing ```c++ by ```c++,ignore |
Followup from #426, and #791.
Right now if you are generating bindings to a C/C++ library that happens to use markdown blocks in its comments, will make rustdoc complain (because the comment probably isn't valid rust).
Right now the workaround is avoiding generating comments, but that's not ideal.
Testcase:
Options I can think off-hand:
Any other ideas @jethrogb?
The text was updated successfully, but these errors were encountered: