Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dunce to canonicalize path instead of std::fs::canonicalize #822

Closed
wants to merge 1 commit into from
Closed

Add dunce to canonicalize path instead of std::fs::canonicalize #822

wants to merge 1 commit into from

Conversation

vipentti
Copy link
Contributor

This closes #821.

@matklad
Copy link
Member

matklad commented Feb 13, 2019

See #821 (comment). I think we should probably just remove canonicalize here?

@matklad
Copy link
Member

matklad commented Feb 13, 2019

bors r+

@matklad
Copy link
Member

matklad commented Feb 13, 2019

bors r-

wrong PR :)

@bors
Copy link
Contributor

bors bot commented Feb 13, 2019

Canceled

@matklad
Copy link
Member

matklad commented Feb 14, 2019

@vipentti let's update this to use current_dir instead of canonicalize?

@vipentti vipentti closed this Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BatchDatabase::load_cargo fails on Windows
2 participants
@vipentti @matklad