feat(ide-completion): extra sugar auto-completion async fn ... in impl trait for async fn in trait that's defined in desugar form
#17737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
hyf0
commented
Jul 29, 2024
hyf0
commented
Jul 29, 2024
| @@ -210,7 +210,7 @@ fn add_function_impl( | |||
| ast::AssocItem::Fn(func) => func, | |||
| _ => unreachable!(), | |||
| }; | |||
|
|
|||
| // TODO: need `function_decl` that unwraps future in the return type | |||
There was a problem hiding this comment.
You'll have to manually traverse the AST here and stitch the edit together, that is something like transformed_fn.ret_type() to fetch the return type, then you can match on that to check if its an ImplTrait one etc
Veykril
added
S-waiting-on-author
…impl trait` for `async fn in trait` that's defined in desugar form
Veykril
force-pushed
the
hyf_32089420384
branch
from
56e8ba6
to
e2e3dbf
Compare
|
Finished up the work here, hope you don't mind :) @bors r+ |
bors
added a commit
that referenced
this pull request
Sep 1, 2024
feat(ide-completion): extra sugar auto-completion `async fn ...` in `impl trait` for `async fn in trait` that's defined in desugar form Solves #17719. --- Preview <img width="670" alt="image" src="https://github.com/user-attachments/assets/64ccef84-4062-4702-8760-89220585f422"> <img width="540" alt="image" src="https://github.com/user-attachments/assets/d22637f9-d531-43b2-a9f1-cd40a002903a"> <img width="631" alt="image" src="https://github.com/user-attachments/assets/21cd2142-bb8e-4493-9ac7-e6a9e7076904">
|
💔 Test failed - checks-actions |
Veykril
force-pushed
the
hyf_32089420384
branch
from
e2e3dbf
to
eb64cc8
Compare
|
@bors r+ |
|
☀️ Test successful - checks-actions |
|
Not at all. Thank you very much. Finally no more manual async anymore :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #17719.
Preview