-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finding all references to functions called new
can take a long time
#7404
Comments
Confirmed:
Seems to burn CPU in |
It basically type-checks the world (every function that has a |
Has this happened? I just came across how long it takes to find all references to a |
It has, I believe it's #7427 |
We're frequently running into this in our codebase, which is about 230 crates large. Any method with a common-enough name like |
This should have been hopefully improved by #17927 |
Sorry for the Materialize dependency, but I think a large-ish codebase is probably necessary to repro this.
To repro:
fn new
inimpl Locald
(as of this writing, it's in src/expr/src/id.rs:45Maybe since finding references involves filtering by a string first, the very common name is what makes things slow? Just a guess.
The text was updated successfully, but these errors were encountered: