Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for installing language server #4753

Closed
ghost opened this issue Jun 5, 2020 · 7 comments
Closed

Better support for installing language server #4753

ghost opened this issue Jun 5, 2020 · 7 comments
Labels
E-medium S-actionable Someone could pick this issue up and work on it right now

Comments

@ghost
Copy link

ghost commented Jun 5, 2020

How can I more reliably install the correct language server version, rather than having to catch the brief alert in vscode before it disappears? If I don't catch that alert to install the language server, rust analyzer seems to silently do nothing.

Context

I do most of my development in docker containers using vscode's remote development in container feature. As such, my dockerfile manages installing rustup, cargo, rustc, clippy, etc. etc., while the devcontainer.json specifies to install the rust analyzer extension after starting the container. For various reasons (such as adding new native dependencies to the container), I regularly have to rebuild these containers -- thus reinstalling the rust analyzer extension.

As noted above, every time I do this I seem to only have one chance to catch a small brief popup that suggests I install a specific language server. I have no idea how to (re)install the language server if I miss this, other than by rebuilding the container.

Versions: Ubuntu 18.04, vscode 1.45.1, every rust analyzer for at least the last month.

I figure I must be missing something, but I can't find any documentation or questions about this.

PS.
Rust analyzer is awesome, thank you all for making the ecosystem so much better

@lnicola
Copy link
Member

lnicola commented Jun 5, 2020

Hmm, why not download the binary from GitHub when building the container?

@ghost
Copy link
Author

ghost commented Jun 6, 2020

I know there are other ways to solve my specific situation (figure out which version to downloadi in the docerfile, mounted volumes etc.), but my more general point is that the documentation states "the plugin will prompt you to download the matching version" and it would be super useful if we could get this same functionality as a command in the palette rather than just having to catch the timed popup.

@lnicola
Copy link
Member

lnicola commented Jun 7, 2020

There's also rust-analyzer.updates.askBeforeDownload which you can probably enable to get rid of the prompt. And I don't think we hide the notification, but rather Code hides it and you can bring it back by clicking on a bell icon in the status bar.

@mickaelistria
Copy link
Contributor

In order to replace RLS by rust-analyzer in Eclipse Corrosion ( eclipse-corrosion/corrosion#315 ), we'd need a rustup -c rust-analyzer. Is this some other place where I can support this idea, or is this ticket enough (note that I personally have no Rust skill to deploy to achieve that, so lobbying is the best I can do at the moment)?

@bjorn3
Copy link
Member

bjorn3 commented Jul 23, 2020

There is already the rust-analyzer-preview rustup component.

@lnicola
Copy link
Member

lnicola commented Jan 18, 2021

I think there are a bunch of alternatives here and there's no need to do anything else. Just to be sure, I tested and the notification didn't go away after a couple of minutes. Even after I dismissed it, I could still click on the bell icon to show it:

image

@lnicola lnicola added the S-actionable Someone could pick this issue up and work on it right now label Jan 18, 2021
@Veykril
Copy link
Member

Veykril commented May 25, 2022

We no longer manage downloads ourselves, so this can be closed.

@Veykril Veykril closed this as completed May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-medium S-actionable Someone could pick this issue up and work on it right now
Projects
None yet
Development

No branches or pull requests

5 participants