Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#[test_log_macros::test] reports unresolved macro panic!() #18411

Closed
Veykril opened this issue Oct 25, 2024 · 6 comments · Fixed by #18422
Closed

#[test_log_macros::test] reports unresolved macro panic!() #18411

Veykril opened this issue Oct 25, 2024 · 6 comments · Fixed by #18422
Assignees
Labels
A-nameres name, path and module resolution C-bug Category: bug

Comments

@Veykril
Copy link
Member

Veykril commented Oct 25, 2024

#[test_log_macros::test]
//^^^^^^^^^^^^^ unresolved macro `panic!`
fn f() {}

with test_log_macros = "0.2.14"

@Veykril Veykril added A-nameres name, path and module resolution C-bug Category: bug labels Oct 25, 2024
@ChayimFriedman2
Copy link
Contributor

Can't reproduce (Windows, VSCode).

@Veykril
Copy link
Member Author

Veykril commented Oct 27, 2024

Hmm odd, I get this in the salsa tests https://github.com/salsa-rs/salsa/

@ChayimFriedman2
Copy link
Contributor

@Veykril
Copy link
Member Author

Veykril commented Oct 27, 2024

@ChayimFriedman2
Copy link
Contributor

Oh I can reproduce now: MCVE:

fn accumulate_execution_order() {
    mod init {
        pub fn init() {
            panic!();
        }
    }
}

I also get another error "no such associated item" on push_logs::accumulated::<Log>(db).

@Veykril
Copy link
Member Author

Veykril commented Oct 27, 2024

I also get another error "no such associated item" on push_logs::accumulated::<Log>(db).

That one is expected, see salsa-rs/salsa#607

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-nameres name, path and module resolution C-bug Category: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants