Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression of derive detection in rust 1.51.0 #10851

Closed
jhgg opened this issue Nov 24, 2021 · 3 comments
Closed

regression of derive detection in rust 1.51.0 #10851

jhgg opened this issue Nov 24, 2021 · 3 comments

Comments

@jhgg
Copy link
Contributor

jhgg commented Nov 24, 2021

in 91bbc55 - the mechanism for detecting a derive macro has changed, in such a way that only works on rust 1.52+ (probably because of rust-lang/rust#79078)

Here we can see that it cannot find the implementation for Default (either in the code lens, "0 implementations", and in the unresolvedReference scope in Foo::default()

image

unfortunately at work we are currently on a nightly on 1.51.0... so this causing a lot of broken analysis. :( took this opportunity to update us to a more recent nightly.

@flodiebold
Copy link
Member

Since we don't usually support older compiler versions, and you updated your version, I think we can close this.

@jhgg
Copy link
Contributor Author

jhgg commented Nov 24, 2021

what is the oldest compiler version ra supports? stable - 1, - 2?

@lnicola
Copy link
Member

lnicola commented Nov 24, 2021

Stable, in theory, but in practice we support more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants