SQL syntax highlighting inside sqlx macros

[Milo123459]

Something like SQL syntax-highlighting inside usage of SQLx macros. This could also provide autocomplete for columns in tables, along with SQL keywords like UPDATE, INSERT, etc.

[lnicola]

How do you see that working?

[Milo123459]

How do you see that working?

There is autocomplete for SQL files, and countless extensions to do that if not provided on install of VSCode; literally that, but inside the SQLx query macro. And for the autocomplete, SQLx actually provides this. The offline feature can do this, but, if it needs to be on the fly a modification would be made to SQLx, or we write something that fetches the data in RA

[lnicola]

Unfortunately, we can't do that, for various technical reasons. And I don't think we should special-case sqlx, nor implement parsing for the three popular SQL dialects it supports.

[flodiebold]

Yeah. We already have #10281 and #7402 for the general solution.

[Milo123459]

Ah, I've done this wrong. I meant overall SQL syntax highlighting, but they look good.

[flodiebold]

So since we're not going to provide any specific SQL support, let's close this in favor of those issues.

[lnicola]

@Milo123459 it's a duplicate of #10281, filed also by you.

[Milo123459]

I am aware. I wanted this one to be more specific

[peri4n]

If you ran into this and use NeoVim. You can use Treesitter to highlight the SQL inside string literals by putting

(macro_invocation
  macro: (scoped_identifier
    path: (identifier) @_path (#eq? @_path "sqlx")
    name: (identifier) @_name (#any-of? @_name "query" "query_as")
  )
  (token_tree 
    (_ (string_content) @injection.content)
    (#set! injection.language "sql")
  )
)

(call_expression
  (scoped_identifier
    path: (identifier) @path (#eq? @path "sqlx")
    name: (identifier) @name (#any-of? @name "query" "query_as"))
  (arguments
    (_ (string_content) @injection.content)
    (#set! injection.language "sql")))

into $USER/.config/neovim/queries/rust/injections.scm

[Milo123459]

Is there an equivalent for vscode?

[peri4n]

I am not a VS Code expert but I don't believe there is. Treesitter support is an open issue: microsoft/vscode#50140

[paulwongx]

To clarify, based on this issue is it normal to see SQL queries inside a sqlx::query_as! macro all in one color like below?