This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Fix tests including dead code warnings #1780
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaKO8Ki
force-pushed
the
fix-tests-including-dead-code-warnings
branch
from
9bfa6b4
to
27f4044
Compare
|
rust-lang/rust#97853 was merged. After a nightly including it is released, this PR should be merged. |
TaKO8Ki
force-pushed
the
fix-tests-including-dead-code-warnings
branch
from
27f4044
to
4c2d97e
Compare
|
Nightly version is still not latest. |
TaKO8Ki
force-pushed
the
fix-tests-including-dead-code-warnings
branch
from
4c2d97e
to
169837a
Compare
|
Closing -- this has landed on master now in ece09b8. See rust-lang/rust#98488, rust-lang/rust#97853 (comment) for context. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is related to rust-lang/rust#97853. In it, I made some changes to collapse multiple dead code warnings into a single diagnostic. They broke some tests in cargo. After rust-lang/rust#97853 is merged, this PR should be merged.