Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

Find definition gives the wrong path for standard library #1140

Closed
0e4ef622 opened this issue Nov 24, 2018 · 6 comments
Closed

Find definition gives the wrong path for standard library #1140

0e4ef622 opened this issue Nov 24, 2018 · 6 comments

Comments

@0e4ef622
Copy link

e.g. looking up Path::join takes me to ~/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/src/src/libstd/path.rs (note the double src/)

@0e4ef622 0e4ef622 changed the title Wrong path in goto definition for standard library Find definition gives the wrong path for standard library Nov 24, 2018
@eddyb
Copy link
Member

eddyb commented Nov 24, 2018

@nrc @alexcrichton @Xanewok This is fallout from rust-lang/rust#53586, AFAICT. I expect RLS is adding src/ to work around the formerly-broken paths, and now that should be removed.

@eddyb
Copy link
Member

eddyb commented Nov 24, 2018

Fix is up at rust-dev-tools/rls-analysis#158.

@nrc
Copy link
Member

nrc commented Nov 25, 2018

rust-dev-tools/rls-analysis#158 is merged. I'll pubish a new version shortly

@spamwax
Copy link

spamwax commented Dec 11, 2018

Tested this both in VSCode and vim LanguageClient, it seems a src is missing

I get
.rustup/toolchains/stable-x86_64-apple-darwin/lib/rustlib/src/rust/libcore/str/mod.rs

where the file is actually at:
.rustup/toolchains/stable-x86_64-apple-darwin/lib/rustlib/src/rust/src/libcore/str/mod.rs

@eddyb
Copy link
Member

eddyb commented Dec 11, 2018

@spamwax Are you up-to-date? Or did this change recently?
EDIT: Nevermind, looks like stable ended up broken (see #1171).

@spamwax
Copy link

spamwax commented Dec 11, 2018

@eddyb
I believe I am. I also just ran rustup update which didn't do anything with stable but failed on nightly saying missing rls, clippy ...
(The crate is using stable channel)

> rustup show

active toolchain
----------------

stable-x86_64-apple-darwin (directory override for '/Volumes/Home/hamid/src/learn/rust/alfred-pinboard-rs')
rustc 1.31.0 (abe02cefd 2018-12-04)

EDIT: closing, reported in #1171

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants