Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention Box's partial field moves #837

Merged
merged 2 commits into from
Nov 5, 2020
Merged

Mention Box's partial field moves #837

merged 2 commits into from
Nov 5, 2020

Conversation

alercah
Copy link
Contributor

@alercah alercah commented Jun 24, 2020

No description provided.

ehuss
ehuss approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems right to me, although I'm unsure about the phrasing since I wouldn't consider Box to be a user-defined type. I'll wait for someone else to weigh in before merging.

@ehuss ehuss added the S-needs-reviewer The pull request poses questions that need to be answered by non-maintainers of the reference label Jul 12, 2020
@Havvy
Copy link
Contributor

Havvy commented Aug 21, 2020

Box is the exception here yes? If so, it should probably say "with the exception of Box" rather than "other than". The "other than" feels like a double negation of the negative at the start making it hard to read.

And yes, Box can be considered a user-defined type. It's very special, but it's still technically a struct.

@Havvy Havvy merged commit 0eb434d into rust-lang:master Nov 5, 2020
@Havvy
Copy link
Contributor

Havvy commented Nov 5, 2020

💟 Thanks!

@ehuss ehuss mentioned this pull request Nov 12, 2020
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 12, 2020
@GuillaumeGomez
Rollup merge of rust-lang#78971 - ehuss:update-books, r=ehuss
4d0f068 
Update books

## nomicon

8 commits in 69333eddb1de92fd17e272ce4677cc983d3bd71d..23c49f1d5ce4720bc5b7e3a920f47eccc8da6b63
2020-10-17 15:44:12 -0700 to 2020-11-05 13:30:53 +0900
-  (rust-lang/nomicon#238)
- Some tweaks (rust-lang/nomicon#244)
-  (rust-lang/nomicon#245)
- Update atomics.md (rust-lang/nomicon#224)
- Update send-and-sync.md (rust-lang/nomicon#187)
- fix a typo (rust-lang/nomicon#231)
- Improve formatting of "Transmutes" chapter (rust-lang/nomicon#242)
- Merge pull request rust-lang/nomicon#241 from simon-lammes/patch-1

## reference

4 commits in 10c16caebe475d0d11bec0531b95d7697856c13c..a7de763c213292f5b44bf10acb87ffa38724814d
2020-10-25 20:51:26 -0700 to 2020-11-11 19:13:21 -0800
- Referencify tuples (rust-lang/reference#899)
- Mention Box's partial field moves (rust-lang/reference#837)
- Enable triagebot (rust-lang/reference#862)
- Update deprecated GitHub Actions commands. (rust-lang/reference#896)

## rust-by-example

1 commits in 99eafee0cb14e6ec641bf02a69d7b30f6058349a..1886fda6981b723e4de637074455558f8bc1e83c
2020-10-21 14:21:55 -0300 to 2020-10-28 13:46:54 -0500
- Remove incorrect "lambda" terminology

## edition-guide

1 commits in 7bc9b7a5e800f79df62947cb7d566fd2fbaf19fe..b91a9a881ee007c12e74e844460ec407cf07a50f
2020-10-23 18:31:23 -0500 to 2020-11-02 11:02:03 -0600
- Clarify slice patterns example (rust-lang/edition-guide#223)
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 12, 2020
@GuillaumeGomez
Rollup merge of rust-lang#78971 - ehuss:update-books, r=ehuss
cac8ac6 
Update books

## nomicon

8 commits in 69333eddb1de92fd17e272ce4677cc983d3bd71d..23c49f1d5ce4720bc5b7e3a920f47eccc8da6b63
2020-10-17 15:44:12 -0700 to 2020-11-05 13:30:53 +0900
-  (rust-lang/nomicon#238)
- Some tweaks (rust-lang/nomicon#244)
-  (rust-lang/nomicon#245)
- Update atomics.md (rust-lang/nomicon#224)
- Update send-and-sync.md (rust-lang/nomicon#187)
- fix a typo (rust-lang/nomicon#231)
- Improve formatting of "Transmutes" chapter (rust-lang/nomicon#242)
- Merge pull request rust-lang/nomicon#241 from simon-lammes/patch-1

## reference

4 commits in 10c16caebe475d0d11bec0531b95d7697856c13c..a7de763c213292f5b44bf10acb87ffa38724814d
2020-10-25 20:51:26 -0700 to 2020-11-11 19:13:21 -0800
- Referencify tuples (rust-lang/reference#899)
- Mention Box's partial field moves (rust-lang/reference#837)
- Enable triagebot (rust-lang/reference#862)
- Update deprecated GitHub Actions commands. (rust-lang/reference#896)

## rust-by-example

1 commits in 99eafee0cb14e6ec641bf02a69d7b30f6058349a..1886fda6981b723e4de637074455558f8bc1e83c
2020-10-21 14:21:55 -0300 to 2020-10-28 13:46:54 -0500
- Remove incorrect "lambda" terminology

## edition-guide

1 commits in 7bc9b7a5e800f79df62947cb7d566fd2fbaf19fe..b91a9a881ee007c12e74e844460ec407cf07a50f
2020-10-23 18:31:23 -0500 to 2020-11-02 11:02:03 -0600
- Clarify slice patterns example (rust-lang/edition-guide#223)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Havvy Havvy Havvy approved these changes

@ehuss ehuss ehuss approved these changes

Assignees
No one assigned
Labels
S-needs-reviewer The pull request poses questions that need to be answered by non-maintainers of the reference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alercah @Havvy @ehuss