Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacked Borrows: test raw-ref-to-field with raw ptr tracking #1614

Merged
merged 5 commits into from
Nov 3, 2020

Conversation

RalfJung
Copy link
Member

Adds a test for rust-lang/rust#78597 (blocked on that landing first)

@RalfJung RalfJung added the S-blocked-on-rust Status: Blocked on landing a Rust PR label Oct 31, 2020
@RalfJung
Copy link
Member Author

RalfJung commented Nov 1, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Nov 1, 2020

📌 Commit 166151f has been approved by RalfJung

@bors
Copy link
Contributor

bors commented Nov 1, 2020

⌛ Testing commit 166151f with merge a3a053a...

bors added a commit that referenced this pull request Nov 1, 2020
Stacked Borrows: test raw-ref-to-field with raw ptr tracking

Adds a test for rust-lang/rust#78597 (blocked on that landing first)
@RalfJung
Copy link
Member Author

RalfJung commented Nov 1, 2020

oops wrong PR that landed.^^

@bors r- retry

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Nov 3, 2020
Retagging: do not retag 'raw reborrows'

When doing `&raw const (*raw_ptr).field`, we do not want any retagging; the original provenance should be fully preserved.

Fixes rust-lang/miri#1608
Test added by rust-lang/miri#1614

Not sure whom to ask for review on this... `@oli-obk` can you have a look? Or maybe highfive makes a good choice.^^
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 3, 2020
Retagging: do not retag 'raw reborrows'

When doing `&raw const (*raw_ptr).field`, we do not want any retagging; the original provenance should be fully preserved.

Fixes rust-lang/miri#1608
Test added by rust-lang/miri#1614

Not sure whom to ask for review on this... `@oli-obk` can you have a look? Or maybe highfive makes a good choice.^^
@RalfJung
Copy link
Member Author

RalfJung commented Nov 3, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Nov 3, 2020

📌 Commit 571b48c has been approved by RalfJung

@bors
Copy link
Contributor

bors commented Nov 3, 2020

⌛ Testing commit 571b48c with merge 2590bc6...

@bors
Copy link
Contributor

bors commented Nov 3, 2020

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 2590bc6 to master...

@bors bors merged commit 2590bc6 into rust-lang:master Nov 3, 2020
@RalfJung RalfJung deleted the raw-retag branch November 4, 2020 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-blocked-on-rust Status: Blocked on landing a Rust PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants