Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix (TLS?) memory leaks on Windows #442

Closed
RalfJung opened this issue Aug 30, 2018 · 1 comment · Fixed by #1269
Closed

Fix (TLS?) memory leaks on Windows #442

RalfJung opened this issue Aug 30, 2018 · 1 comment · Fixed by #1269
Labels
A-leaks Area: affects the memory leak checker A-shims Area: This affects the external function shims A-windows Area: affects only Windows targets C-bug Category: This is a bug.

Comments

@RalfJung
Copy link
Member

We currently ignore memory leaks on Windows. Likely, this is due to not properly executing TLS destructors, but I did not actually investigate. Debugging this requires a libstd with full MIR for Windows, which currently we do not know how to do cross-platform -- so, someone who's actually using Windows should take this.
@RalfJung RalfJung added C-bug Category: This is a bug. A-shims Area: This affects the external function shims labels Nov 17, 2018
@RalfJung RalfJung added the A-windows Area: affects only Windows targets label Apr 8, 2019
@RalfJung RalfJung changed the title Fix memory leaks on Windows Fix (TLS?) memory leaks on Windows Aug 27, 2019
@RalfJung RalfJung mentioned this issue Mar 28, 2020
Merged
@RalfJung
Copy link
Member Author

#1269 mostly fixes this; the remaining problem is memory still reachable through statics, which is tracked at #940.

@bors bors closed this as completed in f274111 Mar 28, 2020
@RalfJung RalfJung added the A-leaks Area: affects the memory leak checker label Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-leaks Area: affects the memory leak checker A-shims Area: This affects the external function shims A-windows Area: affects only Windows targets C-bug Category: This is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

run Windows TLS dtor function RalfJung/miri
1 participant
@RalfJung