Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library depends on same-file #902

Closed
FreeMasen opened this issue Apr 28, 2019 · 1 comment
Closed

Library depends on same-file #902

FreeMasen opened this issue Apr 28, 2019 · 1 comment

Comments

@FreeMasen
Copy link

Currently even the library associated with this project will require that it is compiled on either unix-like or windows target because of a transitive dependency. same-file is a dependency of walkdir which has 2 architecture dependent implementations of it's functionality. While the direct dependency on walkdir is in the dev-dependencies section, which would avoid any issues for users of the mdbook library, it happens to be a dependency of handlebars as well. The handlebars crate has a feature gate to remove this depenency (no_dir_source) which would remove this problem.

According to the unit tests adopting this feature shouldn't break anything.

@Dylan-DPC-zz
Copy link

Fixed by PR linked (#903). Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants