Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline code is styled as display: inline-block #821

Closed
marijnh opened this issue Nov 13, 2018 · 2 comments · Fixed by #1058
Closed

Inline code is styled as display: inline-block #821

marijnh opened this issue Nov 13, 2018 · 2 comments · Fixed by #1058
Labels
A-Style Area: Style (CSS, etc.)

Comments

@marijnh
Copy link

marijnh commented Nov 13, 2018

Besides causing #801 and #750, it also produces undesirable line wrapping behavior (punctuation after a piece of code will wrap to the next line, whereas it should stick to the word before it) and will wrap longer pieces of code inside their own block, rather than along with the rest of the text.

The display: inline-block for code seems to have been introduced ages ago, in 90719f7 , without a clear justification in the patch.

Simply changing the display from inline-block to inline seems to resolve these issues without breaking anything obvious, but since CSS is the gold standard for subtle interaction and global effects, it's hard to be sure. @azerupi Do you remember why you added it?

@mrec
Copy link

mrec commented Feb 27, 2019

In Chrome I need to both change display to inline and disable the vertical-align:middle.

@ehuss ehuss added the A-Style Area: Style (CSS, etc.) label May 17, 2019
@caladd
Copy link
Contributor

caladd commented Oct 6, 2019

I'll take care of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Style Area: Style (CSS, etc.)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants