Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top bar hides section headings when visiting perma links #634

Closed
Emerentius opened this issue Mar 2, 2018 · 6 comments
Closed

Top bar hides section headings when visiting perma links #634

Emerentius opened this issue Mar 2, 2018 · 6 comments

Comments

@Emerentius
Copy link

When visiting the chapter title or the smaller subsection titles via permalinks such as this chapter title or this subsection, the title will be hidden by the top bar. There is no issue for sections (example)

In case you're seeing something different, here's a screenshot

screenshot2

@Michael-F-Bryan
Copy link
Contributor

@sorin-davidoi could this be something to do with how the header floats on top of the page?

@sorin-davidoi
Copy link
Contributor

Yes, most likely. Will take a look in the following days.

@sts10
Copy link

sts10 commented Nov 13, 2018

Just checking: Are there any updates/fixes/work-arounds for this issue? Interestingly, the problem is not present in Firefox for me, but it is Chrome.

Is there something to be changed in #menu-bar in chrome.css?

@sorin-davidoi
Copy link
Contributor

@sts10 I think changes would be needed in autoHideMenu - possibly have a boolean indicate wether the user has ever scrolled (false by default, set to true on the first scroll event) and don't show the menubar if the user has never scrolled (which is the case when they first enter a page).

@sts10
Copy link

sts10 commented Nov 14, 2018

OK, my fix of choice at this point is, in chrome.css on line 73, to change

html:not(.sidebar-visible) #menu-bar:not(:hover).folded > #menu-bar-sticky-container {
    transform: translateY(-60px);
}

to

#menu-bar:not(:hover).folded > #menu-bar-sticky-container {
    transform: translateY(-60px);
}

This change ensures that the top menu will be "hidden" until the user scrolls up, even when the sidebar is opened. This is a pretty good solution for my needs, but I'm not sure it's a change that should be made to the default theme.

@ehuss
Copy link
Contributor

ehuss commented Oct 26, 2019

PR #1077 mostly fixes this, so closing for now.

@ehuss ehuss closed this as completed Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants