-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to add line numbers to default playpen? #1028
Comments
@Michael-F-Bryan I would like to take on this issue. I apologize if you're the wrong person to ping. |
Thanks for volunteering to help, @andymac-2! At a glance, you would need to add a new From there you'll have to figure out how to tell Ace to show/hide line numbers (probably by playing with from the generated HTML, around here somewhere). The context info passed to each handlebars template is done [in the I didn't have much to do with the frontend and am not actively working on |
Already done ;) PR #1035 has the required implementation, and updates the docs accordingly. Thanks for your help! You're the first name that pops up on the |
I notice that the Ace editor can be configured to show/hide line numbers by setting
showLineNumbers
, butmdbook
explicitly sets this to false.I couldn't see a way to pass configuration from my
mdbook
project's.toml
to override this. IMO it would be a big improvement if book authors could configure their editor to show or hide line numbers.The text was updated successfully, but these errors were encountered: