-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
targets: add aero target #2623
targets: add aero target #2623
Conversation
Signed-off-by: Andy-Python-Programmer <[email protected]>
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon. Please see the contribution instructions for more information. |
Signed-off-by: Andy-Python-Programmer <[email protected]>
Signed-off-by: Andy-Python-Programmer <[email protected]>
r? @JohnTitor Could you handle this one? I'm not fully sure what our policy is for adding new targets. |
A bit of information on the project, it does not have any users yet, it cant connect to the internet, it does not currently have X or Wayland, and it doesnt support many unix sycalls, but it may be useful on air-gapped systems in its current form. The project is moving at a quick pace though and I wouldn't be surprised if a bunch of what it doesnt support now will be supported relatively soon. |
is this target supported on rustc? If not, it's generally preferred that you have your own fork of the libc crate and maintain it. |
Though in order to add the target to the rust compiler itself, this needs to be upstreamed. |
If you consider adding a new target, you should follow steps like #2227. Otherwise, reviewers cannot know if you want just to have their own target or to make it an official one. |
Triage: Closing as inactive, feel free to re-open if you find some time to work on. Thanks for the PR anyway! |
Adds the aero target to the libc :^)
Signed-off-by: Andy-Python-Programmer [email protected]