-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linux timer api remove unnecessary double linkage to librt. #2271
linux timer api remove unnecessary double linkage to librt. #2271
Conversation
r? @JohnTitor (rust-highfive has picked a reviewer for you, use r? to override) |
This won't link librt on musl, is it correct behavior? (Moreover, any build with the Lines 302 to 304 in 90aa0e3
|
librt.a of musl is empty file:
And build of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for clarifying! Then it should be fine. There're still some uses of name = "rt"
, I think they all also can be removed, right?
Anyway, this is good to go as-is, let's r+ :)
@bors r+ |
📌 Commit d2b6eab has been approved by |
☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
No description provided.