Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the bors auto r?eassignment on r+ policy #43

Open
Centril opened this issue May 30, 2019 · 4 comments
Open

Implement the bors auto r?eassignment on r+ policy #43

Centril opened this issue May 30, 2019 · 4 comments

Comments

@Centril
Copy link
Contributor

Centril commented May 30, 2019

See:

@Centril
Copy link
Contributor Author

Centril commented May 30, 2019

cc @kennytm

@bryanburgers
Copy link
Contributor

Do you expect homu to set the assignee directly? Or do you expect homu to leave a r? at-person comment?

@Centril
Copy link
Contributor Author

Centril commented Jun 4, 2019

The former would generate least noise in terms of pings so it seems be preferable but the latter is also workable.

@varkor
Copy link
Member

varkor commented Sep 10, 2019

For anyone looking to work on this, you'll want to assign the new reviewer here:

homu/homu/main.py

Lines 567 to 578 in 91da2d8

state.add_comment(comments.Approved(
sha=state.head_sha,
approver=approver,
bot=my_username,
))
treeclosed = state.blocked_by_closed_tree()
if treeclosed:
state.add_comment(
':evergreen_tree: The tree is currently closed for pull requests below priority {}, this pull request will be tested once the tree is reopened' # noqa
.format(treeclosed)
)
state.change_labels(LabelEvent.APPROVED)

I'm not sure if bors already has a way to assign a reviewer, though, as @rust-highfive is usually responsible for that.
Alternatively, it might be easier for @rust-highfive to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants