Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GC the SPPF based on whether a node is still "reachable" #17

Open
eddyb opened this issue Aug 21, 2018 · 1 comment
Open

GC the SPPF based on whether a node is still "reachable" #17

eddyb opened this issue Aug 21, 2018 · 1 comment

Comments

@eddyb
Copy link
Member

eddyb commented Aug 21, 2018

This can be done with ref-counting, but to avoid using an actual Rc (e.g. to be able to do #9) and/or the GSS being more tightly coupled with the SPPF, I'd prefer to use an "unwinding" approach, where we propagate failure up the call-chain, and generate calls to decrement SPPF ref-counts on failure.

May interfere with #12, #13, #16 etc. by removing nodes that could be needed later.

@eddyb
Copy link
Member Author

eddyb commented Sep 18, 2018

We don't have to do "unwinding" right away, we can recover the "stashed" left SPPF children node of a concatenation, from a Continuation (those are the only SPPF nodes kept around by GSS).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant