Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My crate build fails and the build error message is not very informative #2542

Closed
wada314 opened this issue Jul 4, 2024 · 3 comments
Closed

Comments

@wada314
Copy link

wada314 commented Jul 4, 2024

Crate name

protoc-plugin-by-closure

Build failure link

https://docs.rs/crate/protoc-plugin-by-closure/0.1.3/builds/1281496

Additional details

Hello! As title says, my relatively-trivial crate is failing to build in docs.rs and the error message is not very useful.
My crate is just a single lib.rs src file... Just one special thing I can imagine is that it's depending on a cargo unstable feature bindeps so the crate is containing .cargo/config.toml file with a simple content:

[unstable]
bindeps = true

and the crate is depending on an binary-only carte protoc-plugin-bin.

My repository dir

thanks in advance,

@syphar
Copy link
Member

syphar commented Jul 10, 2024

the actual error is:

error: failed to parse manifest at /home/cratesfyi/workspace-builder/builds/protoc-plugin-by-closure-0.1.3/source Cargo.toml
Caused by:
artifact = … requires -Z bindeps (protoc-plugin-bin)

( I need to check why this part is missing in the logs )

@syphar
Copy link
Member

syphar commented Aug 13, 2024

short research result:

for these pre-build errors we just render the error variant we get, in this case rustwide::CommandError, which only contains the status code.

We additionally need to collect & show the output in the cases the error is coming from cargo commands.

( not sure if we should add this to rustwide, or use LogStorage from inside docs.rs)

@syphar
Copy link
Member

syphar commented Oct 18, 2024

#2635 should help with this

@syphar syphar closed this as completed Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants