Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crate license is incorrectly shown for previous versions #227

Closed
limeburst opened this issue Nov 25, 2015 · 5 comments
Closed

Crate license is incorrectly shown for previous versions #227

limeburst opened this issue Nov 25, 2015 · 5 comments

Comments

@limeburst
Copy link

How to reproduce this issue:

  1. Release a version of a crate with any license.
  2. Release a new version with a new license.
  3. Clicking on the old version does not update the page to show the old license.
@Turbo87
Copy link
Member

Turbo87 commented Nov 26, 2015

I don't think that "ui" is the right label. https://github.com/rust-lang/crates.io/blob/master/src/krate.rs#L52 shows that the backend is providing the license information only per crate, not per version. Once the information is available on the backend it should be an easy change on the frontend

@alexcrichton
Copy link
Member

Oh, right! I forgot about that as an implementation detail. Yeah currently we don't track license-per-version but rather license-per-crate, so that'd explain the behavior here!

@est31
Copy link
Member

est31 commented May 22, 2017

Why was this closed? This is an oversight and should be fixed.

@carols10cents
Copy link
Member

@est31

Why was this closed? This is an oversight and should be fixed.

This was closed because it's a bug report, but the system is behaving as designed. Feel free to open a new issue proposing that the way we track licenses be changed to per-version rather than per-crate for discussion.

@est31
Copy link
Member

est31 commented May 22, 2017

@carols10cents opened: #736

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants