From 903da139959380b7143b87b91bc16d4156557da2 Mon Sep 17 00:00:00 2001 From: Tobias Bieniek Date: Mon, 28 Dec 2020 10:23:25 +0100 Subject: [PATCH] Remove "Authors" section from crate details page --- app/components/crate-sidebar.hbs | 9 --------- app/models/version.js | 10 ---------- app/routes/crate/version.js | 4 ---- 3 files changed, 23 deletions(-) diff --git a/app/components/crate-sidebar.hbs b/app/components/crate-sidebar.hbs index e857a2d34bf..be59bd61b32 100644 --- a/app/components/crate-sidebar.hbs +++ b/app/components/crate-sidebar.hbs @@ -85,15 +85,6 @@ {{/each}} - -
-

Authors

- -
diff --git a/app/models/version.js b/app/models/version.js index afe70583af9..aed422238fd 100644 --- a/app/models/version.js +++ b/app/models/version.js @@ -25,7 +25,6 @@ export default class Version extends Model { @belongsTo('crate', { async: false }) crate; @belongsTo('user', { async: false }) published_by; - @hasMany('users', { async: true }) authors; @hasMany('dependency', { async: true }) dependencies; @hasMany('version-download', { async: true }) version_downloads; @@ -97,15 +96,6 @@ export default class Version extends Model { .map(name => ({ name, isDefault: defaultFeatures.includes(name), dependencies: features[name] })); } - @alias('loadAuthorsTask.last.value') authorNames; - - @(task(function* () { - // trigger the async relationship to load the content - let authors = yield this.authors; - return authors.meta.names; - }).keepLatest()) - loadAuthorsTask; - @alias('loadDepsTask.last.value.normal') normalDependencies; @alias('loadDepsTask.last.value.build') buildDependencies; @alias('loadDepsTask.last.value.dev') devDependencies; diff --git a/app/routes/crate/version.js b/app/routes/crate/version.js index 6243fd09545..7402d6b5ecb 100644 --- a/app/routes/crate/version.js +++ b/app/routes/crate/version.js @@ -32,10 +32,6 @@ export default class VersionRoute extends Route { setupController(controller, model) { super.setupController(...arguments); - if (!model.version.authorNames) { - model.version.loadAuthorsTask.perform(); - } - controller.loadReadmeTask.perform().catch(() => { // ignored });