Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --print=all-target-specs-json unstable flag #600

Closed
2 of 3 tasks
pietroalbini opened this issue Mar 9, 2023 · 3 comments
Closed
2 of 3 tasks

Add --print=all-target-specs-json unstable flag #600

pietroalbini opened this issue Mar 9, 2023 · 3 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@pietroalbini
Copy link
Member

pietroalbini commented Mar 9, 2023

Proposal

This MCP proposes to add the unstable --print=all-target-specs-json compiler flag in addition to the existing unstable --print=target-spec-json flag. The flag will output to the standard output the JSON representation of all builtin target specs, emitting a (sorted) map with the target name as the key and the target spec as the value:

{
  "aarch64-apple-darwin": {
    "abi-return-struct-as-int": true,
    "arch": "aarch64",
    ...
  },
  "aarch64-apple-ios": {
    "abi-return-struct-as-int": true,
    "arch": "aarch64",
    ...
  },
  ...
}

This is needed by rust-lang/rust#108905, as it needs to know the details of all targets in order to validate compiletest directives like only-windows and ignore-x86_64. The alternative of invoking --print=target-list and then iterating each target with --print=target-spec-json takes around 5 seconds on my machine, which is not great.

Mentors or Reviewers

If you have a reviewer or mentor in mind for this work, mention then
here. You can put your own name here if you are planning to mentor the
work.

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

@pietroalbini pietroalbini added T-compiler Add this label so rfcbot knows to poll the compiler team major-change A proposal to make a major change to rustc labels Mar 9, 2023
@rustbot
Copy link
Collaborator

rustbot commented Mar 9, 2023

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

cc @rust-lang/compiler @rust-lang/compiler-contributors

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Mar 9, 2023
@Mark-Simulacrum
Copy link
Member

@rustbot second

This is an unstable flag and we can remove it if we decide there's a better alternative. For now I think this makes sense to add.

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Mar 9, 2023
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Mar 23, 2023
@apiraino
Copy link
Contributor

@rustbot label -final-comment-period +major-change-accepted

@rustbot rustbot added major-change-accepted A major change proposal that was accepted to-announce Announce this issue on triage meeting and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Mar 23, 2023
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Development

No branches or pull requests

4 participants