Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hexagon] Remove aliases w/o leading __ #682

Merged
merged 1 commit into from
Sep 1, 2024

Commits on Aug 31, 2024

  1. [hexagon] Remove aliases w/o leading __

    These hexagon builtins incorrectly created aliases in the global
    namespace which can (and in at least one case, did) conflict
    with symbols defined by other programs.
    
    This should address the issue reported as rust-lang/rust#129823:
    
    	   Compiling compiler_builtins v0.1.123
    	   Compiling core v0.0.0 (/home/ben/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core)
    	   Compiling rustc-std-workspace-core v1.99.0 (/home/ben/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/rustc-std-workspace-core)
    	   Compiling byteorder v1.5.0
    	   Compiling zerocopy v0.7.34
    	error: symbol 'fma' is already defined
    
    	error: could not compile `compiler_builtins` (lib) due to 1 previous error
    
    Also: some of the symbols defined were not just aliases, so those are
    now qualified with `__hexagon_`.  The compiler does not yet emit calls
    to these particular ones, but if/when it does, it can use the new names.
    androm3da committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    95c6236 View commit details
    Browse the repository at this point in the history