Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes rustc argument from --force-warns to --force-warn #9714

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Changes rustc argument from --force-warns to --force-warn #9714

merged 1 commit into from
Jul 22, 2021

Conversation

PTNobel
Copy link
Contributor

@PTNobel PTNobel commented Jul 22, 2021

The rustc argument was renamed in rust-lang/rust#87346 breaking cargo fix on the nightly toolchain.

I encountered this while attempting to test Edition 2021 migrations.

I ran RUSTC=/path/to/nightly/rustc cargo test and encountered a few failing tests, but none of them seemed at all related to the 1 line I changed, so if they crop up in CI as well, would love some help on identifying what's causing that.

Closes rust-lang/rust#87360

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon.

Please see the contribution instructions for more information.

@ehuss
Copy link
Contributor

ehuss commented Jul 22, 2021

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Jul 22, 2021

📌 Commit 3dc2018 has been approved by ehuss

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2021
@bors
Copy link
Contributor

bors commented Jul 22, 2021

⌛ Testing commit 3dc2018 with merge cebef29...

@bors
Copy link
Contributor

bors commented Jul 22, 2021

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing cebef29 to master...

@bors bors merged commit cebef29 into rust-lang:master Jul 22, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 22, 2021
Update cargo

2 commits in 4e143fd131e0c16cefd008456e974236ca54e62e..cebef2951ee69617852844894164b54ed478a7da
2021-07-20 21:55:45 +0000 to 2021-07-22 13:01:52 +0000
- Changes rustc argument from `--force-warns` to `--force-warn` (rust-lang/cargo#9714)
- Display registry name instead of registry URL when possible (rust-lang/cargo#9632)
@PTNobel PTNobel deleted the fix-force-warn branch July 22, 2021 21:46
@ehuss ehuss added this to the 1.55.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo fix --edition fails with error "Unrecognized option: 'force-warns'"
4 participants