Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display registry name instead of registry URL when possible #9632

Merged
merged 6 commits into from
Jul 21, 2021
Merged

Display registry name instead of registry URL when possible #9632

merged 6 commits into from
Jul 21, 2021

Commits on Jul 21, 2021

  1. Reuse crate-io constant

    @weihanglo
    weihanglo committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    9244a42 View commit details
    Browse the repository at this point in the history

  2. Show registry name in messages if possible 

    This fixes most messages to display registry names instead of URLs.
    @weihanglo
    weihanglo committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    71f5e92 View commit details
    Browse the repository at this point in the history

  3. Show registry name when using source replacment

    @weihanglo
    weihanglo committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    b8ddbd2 View commit details
    Browse the repository at this point in the history

  4. Show registry name for SourceId from lockfile 

    Since current lockfile does not serialize any registry names. We here
try best effort to restore registry name from either `[registries]`
table or `[source]` replacement table. This is done by manually
implementing `Hash` and `PartialEq` for `SourceIdInner`, of which two
traits previously are simply `derive`d.

To make `SourceIdInner` generate the same hash whether contains `name`
field or not, here we remove `name` field from hashing and only concern
about `kind`, `precise` and `canonical_url`.
    @weihanglo
    weihanglo committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    7720662 View commit details
    Browse the repository at this point in the history

  5. Use crates-io instead of crates.io as registry name

    @weihanglo
    weihanglo committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    4efaa4e View commit details
    Browse the repository at this point in the history

  6. Update tests to use registry names

    @weihanglo
    weihanglo committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    8c75e2f View commit details
    Browse the repository at this point in the history