-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LTO to the metadata filename hash. #8755
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
@bors: r+ |
📌 Commit 6225143b2ab203ed1cf6bf443261c71a09bae84b has been approved by |
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message
|
☔ The latest upstream changes (presumably #8754) made this pull request unmergeable. Please resolve the merge conflicts. Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:
|
@bors r=alexcrichton |
📌 Commit a2e48fd has been approved by |
☀️ Test successful - checks-actions |
Update cargo 3 commits in 75615f8e69f748d7ef0df7bc0b064a9b1f5c78b2..9d1a4863abd9237dbf9d1b74c78632b6a205f6bb 2020-09-29 18:42:19 +0000 to 2020-10-05 18:29:52 +0000 - Add LTO to the metadata filename hash. (rust-lang/cargo#8755) - Fix dylib+rlib with LTO. (rust-lang/cargo#8754) - Homepage doc cargo metadata (rust-lang/cargo#8744)
There are some rare cases where different cargo commands end up building dependencies with different LTO settings. This adds the LTO value to the filename hash so that the cache does not thrash when switching between these commands.
Fixes #8669