Remove unused feature filter. #7131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors: r+ Ok I've spent some time paging this back in and trying to understand it. I'm pretty sure that this is correct (and having a green test suite is a good gut check) and we've always got nightly testing to weed out any issues if they come up anyway. |
|
📌 Commit f1bf382 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jul 15, 2019
Remove unused feature filter. NOTE: Do not merge this lightly. This upended my understanding of how the resolver handles features, and I'm still not sure about it. Remove an unused check that an optional dependency is activated. This was originally added 4 years ago in #1812, during a time when this code iterated over the actual dependencies from `Package.dependencies()`. In #5415 this was refactored so that it gets the `deps` list directly from the Resolver, which AFAIK has already filtered out the features. IIUC, this filtering is done [here](https://github.com/rust-lang/cargo/blame/705009eb3828123cc9dbcf5b28988cc63f60b03b/src/cargo/core/resolver/dep_cache.rs#L270-L272).
|
☀️ Test successful - checks-travis, status-appveyor |
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Jul 17, 2019
Update mdbook, cargo, books This updates the last of the books using mdbook 0.1, finally removing it from the build. Cargo, the reference, and the rustc book were the last to change. This should have a noticeable impact on CI times. I decided to remove the version switcher from the rustbook tool. It seemed a little awkward keeping it with one version. If we ever need it in the future, we can always add it back, it is a relatively small amount of code. I would just like to avoid the temptation to split the versions in the future. ## cargo 12 commits in 677a180f4c8ca1dcef594f68dd0e63e4f08621f5..e3563dbdcd2e370bc4f11d080f739d82d25773fd 2019-07-08 13:43:02 +0000 to 2019-07-16 19:22:44 +0000 - Add Cirrus CI badge to manifest (rust-lang/cargo#7119) - Update mdbook to 0.3. (rust-lang/cargo#7140) - Remove unused feature filter. (rust-lang/cargo#7131) - Remove now-unused `WorkspaceResolve` (rust-lang/cargo#7127) - Fix some clippy warnings. (rust-lang/cargo#7135) - Also ignore remap-path-prefix in metadata for `cargo rustc`. (rust-lang/cargo#7134) - Fix some formatting for some strings. (rust-lang/cargo#7129) - Handle activation conflicts for `[patch]` sources (rust-lang/cargo#7118) - [BETA] Fix `cargo new` in root directory. (rust-lang/cargo#7126) - Remove MyFnOnce (rust-lang/cargo#7125) - Don't suppress error messages with `-q` (rust-lang/cargo#7116) - Fix changelog date (rust-lang/cargo#7115) ## book 2 commits in 6c0d83499c8e77e06a71d28c5e1adccec278d4f3..7ddc46460f09a5cd9bd2a620565bdc20b3315ea9 2019-06-23 20:25:30 -0400 to 2019-06-27 09:50:36 -0400 - reexport to re-export - Fixes made in final layout check ## reference 4 commits in 7a5aab5..8e7d614 2019-06-20 17:38:52 +0200 to 2019-07-16 21:02:33 +0100 - Update to mdbook 0.3. (rust-lang/reference#641) - Remove extra parenthesis (rust-lang/reference#621) - Correct sentence about unsized coercions (rust-lang/reference#628) - unions: call out field offset issues (rust-lang/reference#627) ## edition-guide 4 commits in f8072acde5ce29c7570d7986180bbded2d22e287..f6c8b92d4e63edd28e862be952f33861f35956f8 2019-06-14 23:27:05 +0200 to 2019-07-06 22:10:32 +0200 - Fix syntax highlighting in macro guide (rust-lang/edition-guide#182) - Fix error example for modern compilers. (rust-lang/edition-guide#160) - Try cargo install-upgrade for mdbook. (rust-lang/edition-guide#181) - correct the travis build badge URL (rust-lang/edition-guide#180) ## embedded-book 2 commits in ef27b517dcd0b990c888c0d7caeff52a5a115619..ff334e74fdb9f197e621efa6d7c3105be892e888 2019-06-18 22:59:47 +0000 to 2019-07-16 13:47:34 +0000 - use_core() is required for #![no_std] compatible generated bindings (rust-embedded/book#197) - concurrency: update shared resource examples (rust-embedded/book#196) ## nomicon 7 commits in 341c221116a8b9f1010cf1eece952b80c5ec7f54..b7f0aba2f88a8feade70595efcfa3438e54e96c0 2019-06-19 09:08:47 -0700 to 2019-07-11 15:11:36 -0400 - chore: Remove redundant Eq import - Fix link to rfc1857 - Move word "reading" out of the link to "The Book" - update the link to `mdbook` - re-wrap more text - re-wrap the text to 80 columns - Better explain how to use `mdbook` ## rust-by-example 8 commits in 62b3ff2cb44dd8b648c3ef2a9347c3706d148014..e3679e214d8db44586aca9b20aa27517007d1923 2019-06-24 09:17:21 -0300 to 2019-07-15 11:13:44 -0300 - Collection of fixes for the 'Vectors` chapter. (rust-lang/rust-by-example#1216) - Changed mutable collected_iterator into immutable (rust-lang/rust-by-example#1219) - Fix minor formatting inconsistencies (rust-lang/rust-by-example#1220) - Make `use` example runnable (rust-lang/rust-by-example#1215) - Fix: Automatically Typo (rust-lang/rust-by-example#1214) - Collection of fixes for the `Strings` chapter. (rust-lang/rust-by-example#1212) - Added link to russian translation (rust-lang/rust-by-example#1213) - A couple of fixes for the `HashMap` chapter. (rust-lang/rust-by-example#1211)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Do not merge this lightly. This upended my understanding of how the resolver handles features, and I'm still not sure about it.
Remove an unused check that an optional dependency is activated.
This was originally added 4 years ago in #1812, during a time when this code iterated over the actual dependencies from
Package.dependencies(). In #5415 this was refactored so that it gets thedepslist directly from the Resolver, which AFAIK has already filtered out the features. IIUC, this filtering is done here.