-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: export repository information #6096
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
The repository string is made available via the `CARGO_PKG_REPOSITORY` environment variable similar to other metadata.
3953359
to
07f872a
Compare
Looks great to me, thanks! Just to confirm with others let's... @rfcbot fcp merge |
Or perhaps just, @rust-lang/cargo any objections to adding this? |
Can we clarify in the docs that this is the |
Also updated for homepage and description (though I would assume that |
Though |
Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged teams: No concerns currently listed. Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
@bors: r+ |
📌 Commit ae6b2f6 has been approved by |
build: export repository information The repository string is made available via the `CARGO_PKG_REPOSITORY` environment variable similar to other metadata.
☀️ Test successful - status-appveyor, status-travis |
Some fingerprint cleanup. Just a minor cleanup. Move `CARGO_PKG_*` values from Metadata to Fingerprint (added in #3857). Closes #6208. This prevents stale artifacts from being left behind when these values change. Also tracks changes to the "repository" value (added in #6096). Remove `edition` as a separate field. It is already tracked in `target`. This was required previously to #5816 which added per-target editions. Also adds a helper to the testsuite to make globbing easier.
The repository string is made available via the
CARGO_PKG_REPOSITORY
environment variable similar to other metadata.